[PATCH] D89787: [AsmParser] Add source location to all errors related to .cfi directives

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 30 09:24:55 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp:245
   case MCCFIInstruction::OpDefCfaOffset:
-    OutStreamer->emitCFIDefCfaOffset(Inst.getOffset());
+    OutStreamer->emitCFIDefCfaOffset(Inst.getOffset(), Loc);
     break;
----------------
These can be simplified by switching to default arguments in the declarations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89787/new/

https://reviews.llvm.org/D89787



More information about the llvm-commits mailing list