[PATCH] D87114: [CMake][ExecutionEngine] convert HAVE_EHTABLES_SUPPORT to a real config.h macro

Fri Oct 30 08:03:46 PDT 2020

daltenty added inline comments.

================
Comment at: llvm/include/llvm/Config/config.h.cmake:62
+/* Define to 1 if we can register EH tables on this platform. */
+#cmakedefine01 HAVE_EHTABLE_SUPPORT
+
----------------
hubert.reinterpretcast wrote:
> I think the name is not appropriate in the wider context. I suggest having separate config variables for each of the functions (like the one for `_Unwind_Backtrace`) and then using those to define `HAVE_EHTABLE_SUPPORT` where it is defined before this patch.
I think that makes sense, though I'd prefer to drop the macro  `HAVE_EHTABLE_SUPPORT` entirely then. What this code is really looking for the presence of the registration / deregistration functions anyway, nothing else.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87114/new/

https://reviews.llvm.org/D87114