[PATCH] D89934: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Depend clause

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

Thanks for the patch. A few questions inline.



================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:651
+            context_.Say(GetContext().clauseSource,
+                "A variable that is part of another variable "
+                "(such as an element of a structure) but is not an array "
----------------
Can you check whether this is dropped from OpenMP 5.0. If so I would prefer to skip this check.


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:658
+            context_.Say(GetContext().clauseSource,
+                "Coarrays are not supported in DEPEND clause"_err_en_US);
+          },
----------------
Can you add a test for this error?
Is this restriction from some other section or from a general point that Fortran features like Block, coarrays etc are not supported?


================
Comment at: flang/lib/Semantics/check-omp-structure.h:165-167
+  void CheckDependList(const parser::DataRef &);
+  void CheckDependArraySection(
+      const common::Indirection<parser::ArrayElement> &, const parser::Name &);
----------------
Can these be private?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89934/new/

https://reviews.llvm.org/D89934