[PATCH] D90451: [AMDGPU] Fix lowering of S_MOV_{B32,B64}_term

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 30 06:54:18 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeExecMasking.cpp:183
   case AMDGPU::S_MOV_B32_term: {
-    MI.setDesc(TII.get(AMDGPU::COPY));
+    bool ImmSrc = MI.getOperand(1).isImm();
+    MI.setDesc(TII.get(ImmSrc ? AMDGPU::S_MOV_B32 : AMDGPU::COPY));
----------------
!isReg would be more accurate


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90451/new/

https://reviews.llvm.org/D90451



More information about the llvm-commits mailing list