[PATCH] D90453: [llvm-exegesis] Print signal name when the snippet crashed.

[Clement Courbet via Phabricator via llvm-commits]

courbet created this revision.
courbet added a reviewer: gchatelet.
Herald added a subscriber: mstojanovic.
Herald added a project: LLVM.
courbet requested review of this revision.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D90453

Files:
  llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp


Index: llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp
===================================================================
--- llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp
+++ llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp
@@ -101,9 +101,19 @@
           Counter->stop();
         });
         CrashRecoveryContext::Disable();
-        // FIXME: Better diagnosis.
-        if (Crashed)
-          return make_error<SnippetCrash>("snippet crashed while running");
+        if (Crashed) {
+          std::string Msg = "snippet crashed while running";
+#ifdef LLVM_ON_UNIX
+          // See "Exit Status for Commands":
+          // https://pubs.opengroup.org/onlinepubs/9699919799/xrat/V4_xcu_chap02.html
+          constexpr const int kSigOffset = 128;
+          if (const char *const SigName = strsignal(CRC.RetCode - kSigOffset)) {
+            Msg += ": ";
+            Msg += SigName;
+          }
+#endif
+          return make_error<SnippetCrash>(std::move(Msg));
+        }
       }
 
       auto ValueOrError = Counter->readOrError(Function.getFunctionBytes());


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90453.301852.patch
Type: text/x-patch
Size: 1077 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201030/715b034c/attachment.bin>