[PATCH] D90386: [ADT] Add methods to SmallString for efficient concatenation

Nathan James via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 30 02:43:56 PDT 2020


njames93 added a comment.

In D90386#2363594 <https://reviews.llvm.org/D90386#2363594>, @dblaikie wrote:

> Looks good -please add a test for the assign function this patch adds too.

There already is an assign test, should probably improve the append test so the string isn't empty before hand


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90386/new/

https://reviews.llvm.org/D90386



More information about the llvm-commits mailing list