[PATCH] D89650: [DSE] Remove noop stores after killing stores for a MemoryDef.

Fri Oct 30 02:32:23 PDT 2020

fhahn added a comment.

In D89650#2362379 <https://reviews.llvm.org/D89650#2362379>, @zoecarver wrote:

>> Click on Accept to formally approve it.
>
> I wasn't sure if I was allowed to. For example, in libc++ for a while (not anymore), only maintainers were allowed to approve patches.

Thanks for taking a look! There are no hard rules I am aware of and generally all comments are very welcome!

As for the 'official' approval, I think it depends a lot on the complexity of the patch and if in doubt it is probably best to wait for feedback from a reviewer that already reviewed patches in the area, in addition to other approvals.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89650/new/

https://reviews.llvm.org/D89650