[PATCH] D89518: [windows-itanium] Add Windows Itanium How-To Guide

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: llvm/docs/HowToBuildWindowsItaniumPrograms.rst:116
+
+The CMake files will need to be edited to prevent them adding GNU specific libraries to the link line.
+
----------------
For my builds, as long as I'm using `LIBUNWIND_USE_COMPILER_RT`, it links clang-rt.builtins instead of libgcc, but I guess there's a need for more options there.


================
Comment at: llvm/docs/HowToBuildWindowsItaniumPrograms.rst:127
+into the libc++ DLL. This necessitates editing the CMake file
+to ensure that the visibility macros (which expand to dllexport/import)
+are expanded as they will be needed when creating the final libc++
----------------
I hadn't noticed this wording here before, but this editing of cmake files to tweak visibility macros pretty much amounts to https://reviews.llvm.org/D90021 I guess? Hopefully that one (in whichever form I tweak it to) works for your case as well, to avoid any need for manual modifications.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89518/new/

https://reviews.llvm.org/D89518