[PATCH] D89723: [CSSPGO][llvm-profgen]Context-sensitive profile data generation

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:361
+            if (PreOffset != 0) {
+              PrologEpilogSet.insert(PreOffset);
+            }
----------------
hoy wrote:
> Please comment here and below that the prolog/epilog built here is based on an estimated size. Dwarf decoding is needed for a building precise prolog/epilog. 
> 
> Also how about separating the code to form a prolog/epilog builder that can be based on `FuncStartAddrMap`? The builder will be based on Dwarf CFI in the future.
Agree it's cleaner to decouple from the main disasm loop. For now a separate function `trackPrologEpilog` should be enough. (btw, if we need to extend to a class in the future, tracker may be better name than builder..)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89723/new/

https://reviews.llvm.org/D89723