[PATCH] D90438: [llvm-objcopy] Make --set-section-flags work with --add-section

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 30 00:19:02 PDT 2020


MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/add-section-and-set-flags.test:4
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-objcopy --add-section=foo=/dev/null --set-section-flags=foo=alloc,exclude %t %t.out
+# RUN: llvm-readobj -S %t.out | FileCheck %s
----------------
grimar wrote:
> `GNU objcopy (GNU Binutils for Ubuntu) 2.31.1` doesn't recognize `exclude`, btw:
> 
> objcopy: unrecognized section flag `exclude'
> objcopy: supported flags: alloc, load, noload, readonly, debug, code, data, rom, share, contents, merge, strings
> 
Right. I added 'exclude' to GNU objcopy 2.35 :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90438/new/

https://reviews.llvm.org/D90438



More information about the llvm-commits mailing list