[PATCH] D89105: [X86] Support Intel avxvnni

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 29 23:06:38 PDT 2020


pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.

LGTM with little nit:



================
Comment at: llvm/test/CodeGen/X86/avx-vnni/avx_vnni-intrinsics.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=i686-unknown-unknown -mattr=+avxvnni --show-mc-encoding | FileCheck %s --check-prefixes=CHECK,AVX-X86
+; RUN: llc < %s -mtriple=i686-unknown-unknown -mattr=+avx512vnni,+avx512vl,+avxvnni --show-mc-encoding | FileCheck %s --check-prefixes=CHECK,AVX512-X86
----------------
I don't see difference between `AVX-X86` and `AVX-X64`, maybe you can use `AVX` for both, or `AVX,AVX-X86` and `AVX,AVX-X64` if they do have some differences. And remove `CHECK` since it never been used.


================
Comment at: llvm/test/CodeGen/X86/avx-vnni/avx_vnni-intrinsics.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=i686-unknown-unknown -mattr=+avxvnni --show-mc-encoding | FileCheck %s --check-prefixes=CHECK,AVX-X86
----------------
Do we need new directory for the tests?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89105/new/

https://reviews.llvm.org/D89105



More information about the llvm-commits mailing list