[PATCH] D79057: [mlir][SCCP] Track all source dialects when meeting two lattice values

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.
Herald added subscribers: rdzhabarov, tatianashp, msifontes, jurahul, stephenneuendorffer, aartbik.
Herald added a project: MLIR.


================
Comment at: mlir/lib/Transforms/SCCP.cpp:30
 namespace {
 /// This class represents a single lattice value. A lattive value corresponds to
 /// the various different states that a value in the SCCP dataflow anaylsis can
----------------



================
Comment at: mlir/lib/Transforms/SCCP.cpp:31
 /// This class represents a single lattice value. A lattive value corresponds to
 /// the various different states that a value in the SCCP dataflow anaylsis can
 /// take. See 'Kind' below for more details on the different states a value can
----------------



================
Comment at: mlir/lib/Transforms/SCCP.cpp:300
+  /// 'ownerDialect' corresponds to the source dialect of 'to' or 'from'. This
+  /// is added to 'to' if it resolves to a constant.
+  void meet(Value value, Dialect *dialect, LatticeValue &to,
----------------
This comment is confusing to me:
- ownerDialect does not match a parameter
- `**the** source dialect of 'to' or 'from'` : this revision is updating LatticeValue to have a set of dialects, also it isn't clear what this means in the context of the caller (it does not help me to know how to call this API properly)
- "'to' corresponds to a value whose uses should be visited if the meet changed" => I think you meant "value" instead of "to" here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79057/new/

https://reviews.llvm.org/D79057