[PATCH] D90391: [gvn] PRE needs to skip convergent intrinsics/calls.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 29 22:31:38 PDT 2020


jdoerfert added inline comments.


================
Comment at: llvm/test/Transforms/GVN/pre-skip-convergent.ll:1
+; RUN: opt -S -gvn -o - %s | FileCheck %s
+
----------------
mkazantsev wrote:
> Please commit this test without your patch with auto-generated checks (`utils/update_test_checks.py`), then rebase on top of it to show what your patch changes.
You probably also want to add a run line for the new pass manager `-passes=...`, assuming we run this code in the new PM. (Ignore this if we don't).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90391/new/

https://reviews.llvm.org/D90391



More information about the llvm-commits mailing list