[PATCH] D89105: [X86] Support Intel avxvnni

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: clang/lib/Headers/avxvnniintrin.h:31
+
+/* Below intrinsics defined in avx512vlvnniintrin.h can be used for */
+/// \fn __m256i _mm256_dpbusd_epi32(__m256i __S, __m256i __A, __m256i __B)
----------------
Missing one line comment?


================
Comment at: clang/lib/Headers/immintrin.h:144
 #if !(defined(_MSC_VER) || defined(__SCE__)) || __has_feature(modules) ||      \
-    (defined(__AVX512VL__) && defined(__AVX512VNNI__))
+(defined(__AVX512VL__) && defined(__AVX512VNNI__))
 #include <avx512vlvnniintrin.h>
----------------
Change back the spaces.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3851
+      (ForcedVEXEncoding != VEXEncoding_VEX &&
+       ForcedVEXEncoding != VEXEncoding_VEX3))
+    return Match_Unsupported;
----------------
Missing check for VEX2?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89105/new/

https://reviews.llvm.org/D89105