[PATCH] D88286: [NFC][NARY-REASSOCIATE] Restructure code to aviod isPotentiallyReassociatable

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 29 21:29:03 PDT 2020


mkazantsev accepted this revision.
mkazantsev added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/Scalar/NaryReassociate.cpp:292
+  llvm_unreachable("should not be reached");
+  return nullptr;
 }
----------------
Return after unreachable not needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88286/new/

https://reviews.llvm.org/D88286



More information about the llvm-commits mailing list