[PATCH] D89723: [CSSPGO][llvm-profgen]Context-sensitive profile data generation

Thu Oct 29 20:45:59 PDT 2020

wmi added a comment.

In D89723#2363568 <https://reviews.llvm.org/D89723#2363568>, @hoy wrote:

> In D89723#2363556 <https://reviews.llvm.org/D89723#2363556>, @wmi wrote:
>
>> One issue I notice is getCanonicalFnName should be called somewhere to make the context string canonical.
>
> Good point. Is that for LTO-backend static function renaming? The function names recorded in the profile are actually from the Dwarf debug data but not the Elf symbol table. I'd expect the names there should not be touched by the LTO backend. Correct me if I'm missing anything.

Yes, the renaming for LTO local function promotion is one case -- adding ".llvm.xxx" suffix. There are also other cases, like function splitting will add ".cold" suffix. The function name in Dwarf after LTO local function promotion should be consistent with the name in Elf symbol table which contains ".llvm" suffix.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89723/new/

https://reviews.llvm.org/D89723