[PATCH] D89105: [X86] Support Intel avxvnni

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: clang/lib/Headers/avxvnniintrin.h:30
+#define __AVXVNNIINTRIN_H
+
+/* Intrinsics with _avx_ prefix are for compatibility with msvc. */
----------------
pengfei wrote:
> I think we may still need add some information for intrinsics that can be used for `AVXVNNI` but not declared here. A proposal might be:
> 
> ```
> /* Below intrinsics defined in avx512vlvnniintrin.h can be used for */
> /* AVXVNNI except used for compatibility with msvc.                 */
> // #define _mm256_dpbusd_epi32(S, A, B)
> // #define _mm256_dpbusds_epi32(S, A, B)
> // #define _mm256_dpwssd_epi32(S, A, B)
> ...
> ```
I had a look at the Doxygen grammar. Maybe we can use like below:
```
/* Below intrinsics defined in avx512vlvnniintrin.h can be used for */
/* AVXVNNI except used for compatibility with msvc.                 */
/// \fn __m256i _mm256_dpbusd_epi32(__m256i __S, __m256i __A, __m256i __B)
/// \fn __m256i _mm256_dpbusds_epi32(__m256i __S, __m256i __A, __m256i __B)
/// \fn __m256i _mm256_dpwssd_epi32(__m256i __S, __m256i __A, __m256i __B)
...
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89105/new/

https://reviews.llvm.org/D89105