[PATCH] D90438: [llvm-objcopy] Make --set-section-flags work with --add-section

Thu Oct 29 18:33:52 PDT 2020

rupprecht added a comment.

LGTM. I'll wait for a second person to stamp it.

In D90438#2363471 <https://reviews.llvm.org/D90438#2363471>, @MaskRay wrote:

> You may ask what `objcopy --add-gnu-debuglink=a --set-section-flags=.gnu_debuglink=alloc` does. It does not change the flags of `.gnu_debuglink` and thus our behavior matches GNU.
> It seems like an a combo users won't use and I don't bother adding a test.

I wasn't going to, actually :)

Maybe we should allow that, but print a warning that the user is changing flags for a special section, and behavior after that may be unexpected. And apply that warning for other kinds of special sections. That may be beyond the scope of this patch, though.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90438/new/

https://reviews.llvm.org/D90438