[PATCH] D90426: hwasan: Support for outlined checks in the Linux kernel.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:505
+      TargetTriple.isAArch64() && TargetTriple.isOSBinFormatELF() &&
+      (ClInlineAllChecks.getNumOccurrences() ? !ClInlineAllChecks : !Recover);
+
----------------
I don't understand the impact of this diff.
Now, Recover==true no longer overrides an explicit -hwasan-inline-all-checks=1.
Why?
Is that what prevented outlining in the kernel before?


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:510
+      HasMatchAllTag = true;
+      MatchAllTag = ClMatchAllTag;
+    }
----------------
ClMatchTag & 0xF
either here or when constructing AccessInfo


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90426/new/

https://reviews.llvm.org/D90426