[PATCH] D90120: [sanitizer] Print errno for report file open failure

Thu Oct 29 15:28:10 PDT 2020

tejohnson added a comment.

In D90120#2363238 <https://reviews.llvm.org/D90120#2363238>, @vitalybuka wrote:

> Fails on bot http://lab.llvm.org:8011/#/builders/37/builds/275

Yep, saw that one fail too. And finally figured out the issue after staring at the paths again. Its due to macro expansion of the "linux" in the path name with "1" in the path specified to PROFILE_VAR_NAME, since the bot has "-linux" in its name and therefore the path. I've disabled the test again in rGd124ac0c223a <https://reviews.llvm.org/rGd124ac0c223a4d3bd537298140bb8539d6d929eb>, with an explanation of what is going on. I can reproduce it locally on my linux box when I manually compile the test with -DPROFILE_VAR_NAME set to a path with "-linux" in it. I'm not sure how to prevent multiple levels of macros from being expanded in the stringizing sequence. I might just have it pass a hardcoded bad path and test that it gets passed through (via one of the errors like I am checking with CHECK-INVALID).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90120/new/

https://reviews.llvm.org/D90120