[PATCH] D90428: [WebAssembly] Improved LLD error messages in case of mixed wasm32/wasm64 object files
Wouter van Oortmerssen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 29 15:01:16 PDT 2020
aardappel added inline comments.
================
Comment at: lld/wasm/InputFiles.cpp:51
+ fatal(toString(file) +
+ ": wasm32 object file can\'t be linked in wasm64 mode");
+ }
----------------
sbc100 wrote:
> No need to escape single quote is there?
>
> Can we get tests for these new error cases?
You want a test that builds two different .o files and tries to link them? Doesn't that sound a bit overkill for this? Do all LLD errors have tests? Certainly the ones we already had that I am replacing didn't.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90428/new/
https://reviews.llvm.org/D90428
More information about the llvm-commits
mailing list