[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

David Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 29 14:23:34 PDT 2020


dsanders11 added a comment.

> Oh, how neat. The bug you linked to was closed as a dup of another bug. The other bug was then closed as something that's not in scope with the general product direction, whatever that means.

Yea, typical Microsoft/Windows fun there.

> Yeah, that would be reasonable test coverage.

Sounds good. I've updated the revision to remove the `#if` guard and removed `REQUIRES: ansi-escape-sequences` from the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90109/new/

https://reviews.llvm.org/D90109



More information about the llvm-commits mailing list