[PATCH] D90351: [GWP-ASan] Add mutexes for Fuchsia

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 29 14:11:31 PDT 2020


hctim added inline comments.


================
Comment at: compiler-rt/lib/gwp_asan/platform_specific/mutex_fuchsia.cpp:11
+
+#if defined(__Fuchsia__)
+
----------------
hctim wrote:
> Nit: Remove #ifdefs from platform-specific code. Should only be built on that platform, so this should be unnecessary.
(of course i mean platform-specific cpp's here, headers obviously need the guards)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90351/new/

https://reviews.llvm.org/D90351



More information about the llvm-commits mailing list