[PATCH] D90153: [AArch64][AsmParser] Remove 'x31' alias for 'sp/xzr' register.

[Owen Anderson via Phabricator via llvm-commits]

resistor added a comment.

I'll be the dissenting voice: I don't think this is the right approach.  "It's what gas does" is not a sufficient reason to break user code.  I think a warning and *possibly* removing support some time well in the future is the right solution here.

Keep in mind that just because the architecture manual currently says that the name doesn't exist does not mean that it always did.  I'm personally aware of a good bit of aarch64 assembly that was written well before the architecture manual was finalized, and there are definitely instances where the specification of the asm syntax was clarified in ways that are incompatible with how it was original stated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90153/new/

https://reviews.llvm.org/D90153