[PATCH] D90162: [llvm][AArch64] Prevent spurious zero extension.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

This looks like it should be at least two separate changes; I think the AArch64ISelLowering change should have some impact on its own.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:5748
+    if (NarrowVT != LHS.getOperand(0).getValueType())
+      return false;
+
----------------
Shouldn't this be a less-than comparison as opposed to exact equality?  For example, suppose the bitmask is equal to one,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90162/new/

https://reviews.llvm.org/D90162