[PATCH] D89623: [MemCpyOpt] Move GEP during call slot optimization
dmajor via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 29 10:33:37 PDT 2020
dmajor added a comment.
In D89623#2361288 <https://reviews.llvm.org/D89623#2361288>, @nikic wrote:
> @dmajor If the call slot optimization applies, then that load/store pair should also get dropped as part of the optimization. I don't immediately see how we can end up both changing the call argument and not dropping the load/store, if I understand right what is happening in your case.
You're right, I was looking too narrowly at `performCallSlotOptzn`. The IR is sane after `MemCpyOptPass` as a whole. Our badness actually happens later in the pipeline, sorry for the noise.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89623/new/
https://reviews.llvm.org/D89623
More information about the llvm-commits
mailing list