[PATCH] D90113: [DAGCombiner] Fold BinOp into Select containing identity constant

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/dagcombine-select.ll:58-69
+; GCN-LABEL: select_or1:
+; GCN:       ; %bb.0:
+; GCN-NEXT:    s_load_dwordx2 s[2:3], s[0:1], 0x24
+; GCN-NEXT:    s_load_dwordx2 s[0:1], s[0:1], 0x2c
+; GCN-NEXT:    s_waitcnt lgkmcnt(0)
+; GCN-NEXT:    v_cmp_gt_i32_e64 s[4:5], s0, 10
+; GCN-NEXT:    v_cndmask_b32_e64 v0, 0, -1, s[4:5]
----------------
Regression here. The "or" is suppoed to be combined away.


================
Comment at: llvm/test/CodeGen/AMDGPU/sdiv64.ll:576-578
+; GCN-NEXT:    v_add_i32_e32 v2, vcc, 1, v3
 ; GCN-NEXT:    v_cmp_ge_f32_e64 vcc, |v1|, |v0|
+; GCN-NEXT:    v_cndmask_b32_e32 v0, v3, v2, vcc
----------------
Another add-with-carry regression here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90113/new/

https://reviews.llvm.org/D90113