[PATCH] D90342: [POC][LoopVectorizer] Propagate ElementCount to interfaces in preparation for scalable auto-vec.

[Vineet Kumar via Phabricator via llvm-commits]

vkmr added a comment.

Overall looks like a good first step.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:5401
+LoopVectorizationCostModel::selectVectorizationFactor(ElementCount MaxVF) {
+  // This can be fixed for scalable vectors later, as we this prototype is only
+  // able to vectorize a loop when it has the loop-hint to enable vectorization
----------------
Missing words? Typo? (... as we this...)


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7846
   RSO << "Initial VPlan for VF={" << VF;
-  for (VF *= 2; VF.getKnownMinValue() < Range.End; VF *= 2) {
+  assert(VF.isScalable() == Range.End.isScalable() &&
+         "Scalable flags don't match");
----------------
Do we need this assert here?  Wouldn't it be redundant with the assert in the VFRange constructor?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90342/new/

https://reviews.llvm.org/D90342