[PATCH] D89218: [DebugInfo] Support for DW_TAG_generic_subrange

[Alok Kumar Sharma via Phabricator via llvm-commits]

alok marked an inline comment as done.
alok added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp:546
+      assert(!isRegisterLocation());
+      emitSigned(Op->getArg(0));
+      break;
----------------
dstenb wrote:
> alok wrote:
> > alok wrote:
> > > markus wrote:
> > > > Question: aren't we missing a `emitOp(dwarf::DW_OP_consts)` here? AFAICT `emitSigned` is not similar to `emitConstu` in that sense (i.e. the former does not do `emitOp` internally).
> > > Thanks for pointing this out. You are correct this is missed. I plan to commit the correction. I hope this would not require separate review ?
> > This is corrected in commit ID: 930a8c60b60805567e3cc0c7958be3ceeafd01f9
> > Thanks again for pointing this out.
> Okay, thanks! It could probably be good to also add a small regression test using llvm-dwarfdump to verify that the operation is emitted correctly.
Thanks for your suggestion. It is included in commit ID: aa71874f6b9bb9bddca54e9d89d5725dcc77090f


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89218/new/

https://reviews.llvm.org/D89218