[PATCH] D90372: [yaml2obj][test] - Merge strtab-implicit-sections-*.yaml into strtab-implicit-sections.yaml and improve testing of .shstrtab

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/strtab-implicit-sections.yaml:48
+    Type:  SHT_STRTAB
+    Flags: [ SHF_ALLOC, SHF_STRINGS ]
+  - Name: .shstrtab
----------------
Could you use -D to avoid needing a separate YAML block here from the one above?


================
Comment at: llvm/test/tools/yaml2obj/ELF/strtab-implicit-sections.yaml:81-82
+
+# CASE4:      Contents of section .strtab:
+# CASE4-NEXT:  0000 00666f6f 00 .foo.
+
----------------
Should we also check .shstrtab and .dynstr here? Same below.


================
Comment at: llvm/test/tools/yaml2obj/ELF/strtab-implicit-sections.yaml:125
+    Type: SHT_STRTAB
+    Size: 2
+## Used to trigger adding string `foo` to the string table section.
----------------
Could you fold this into the above YAML? Same goes below.


================
Comment at: llvm/test/tools/yaml2obj/ELF/strtab-implicit-sections.yaml:200-201
+
+## For string table sections, check we can specify both `Size` and `Content`
+## when size is equal to content size.
+
----------------
Sounds like we need a test for where the "Size" is less than the content size.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90372/new/

https://reviews.llvm.org/D90372