[PATCH] D90301: [yaml2obj][test] - Merge dynsymtab-shlink.yaml to dynsym-section.yaml

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/dynsym-section.yaml:60
+
+# RUN: yaml2obj %s --docnum=2 -DLINK="" -o %t3
+# RUN: llvm-readelf --section-headers %t3 | FileCheck %s --check-prefix=LINK-DEFAULT
----------------
jhenderson wrote:
> If you used Link: `[[LINK:<none>]]` (or whatever the syntax is), that'll allow you to avoid the `-DLINK=""` bit here, right?
No, because `Link` field is not `Optional<>`, it is StringRef. I can't use `[[LINK:<none>]]` currently.
Perhaps worth changing it to be `Optional` too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90301/new/

https://reviews.llvm.org/D90301