[PATCH] D89826: [FunctionAttrs][NPM] Fix handling of convergent

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 added a comment.

In D89826#2348164 <https://reviews.llvm.org/D89826#2348164>, @nhaehnle wrote:

> Oh, and on the change itself: I'm not familiar enough with the attributor framework to judge the implementation, but the described reasoning (being able to make deductions from indirect calls) is sound.

I might try to add this to attributor soon.



================
Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:1306
+/// does:
+///   - removal of Convergent attribute
+///   - addition of NoUnwind attribute
----------------
Nit: This doesn't remove convergent anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89826/new/

https://reviews.llvm.org/D89826