[PATCH] D90281: [FileCheck] Report missing prefixes when more than one is provided.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/test/FileCheck/allow-unused-prefixes.txt:1
+// RUN: not FileCheck  --allow-unused-prefixes=false --check-prefixes=P1,P2 --input-file %s %s
+// RUN: FileCheck --allow-unused-prefixes=true  --check-prefixes=P1,P2 --input-file %s %s 
----------------
You probably need to test the error reported?


================
Comment at: llvm/test/FileCheck/allow-unused-prefixes.txt:2
+// RUN: not FileCheck  --allow-unused-prefixes=false --check-prefixes=P1,P2 --input-file %s %s
+// RUN: FileCheck --allow-unused-prefixes=true  --check-prefixes=P1,P2 --input-file %s %s 
+
----------------
I think it also worth to add a test for the default value, i.e. when no `--allow-unused-prefixes` is present.


================
Comment at: llvm/test/FileCheck/allow-unused-prefixes.txt:6
+; P1: hello
\ No newline at end of file

----------------
No EOL.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90281/new/

https://reviews.llvm.org/D90281