[PATCH] D88107: [NewPM] Add callbacks to PassBuilder to run before/after parsing a pass

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D88107#2291583 <https://reviews.llvm.org/D88107#2291583>, @aeubanks wrote:

> In D88107#2291548 <https://reviews.llvm.org/D88107#2291548>, @ychen wrote:
>
>> In D88107#2291529 <https://reviews.llvm.org/D88107#2291529>, @aeubanks wrote:
>>
>>> Actually, doing verify-each in StandardInstrumentations seems much nicer. Not sure about how to do debugify-each though, filed https://bugs.llvm.org/show_bug.cgi?id=47633.
>>
>> If debugify-each has or could be made to have a standalone function interface, could it use StandardInstrumentations?
>
> The issue is that it modifies the IR, which can't be done from StandardInstrumentations (invalidating analyses, etc.).
> -verify doesn't modify the IR.

I worked on `test/DebugInfo` from a task list by @aeubanks and found this thread just after I posted my -debugify-each patch D90365 <https://reviews.llvm.org/D90365>:)
Hope it does not collide with any work you are working on:)

I have tried StandardInstrumentations but switched to moving all stuff in Debugify.cpp because that seems cleaner (I don't want things in Debugify.cpp leak to other places).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88107/new/

https://reviews.llvm.org/D88107