[PATCH] D89788: [RISCV] Add GHC calling convention

Wed Oct 28 16:59:05 PDT 2020

luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.

Overall, LGTM. Two things, though:

1. Please fix the `< %s` issue before committing, otherwise the test will fail.
2. Having a test for the error conditions would really round off this patch. I don't think that needs to be a blocker for merging this, but it would be nice.

================
Comment at: llvm/test/CodeGen/RISCV/ghccc-rv32.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=riscv32 -mattr=+f,+d | FileCheck %s
+
----------------
This is missing the `< %s` at the end of the `llc` command options.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89788/new/

https://reviews.llvm.org/D89788