[PATCH] D89995: Make the post-commit review expectations more explicit with respect to revert

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 15:27:10 PDT 2020


dexonsmith accepted this revision.
dexonsmith added a comment.

LGTM with a couple of nits.



================
Comment at: llvm/docs/CodeReview.rst:57
+other development; it's entirely possible the patch will end up being reapplied
+essentially as is once concerns have been resolved.
+
----------------
I think there should be a hyphen in "as-is"


================
Comment at: llvm/docs/CodeReview.rst:63
+a community member with access to hardware similar to that on the buildbot is
+excepted to engage in the review.
 
----------------
typo, should be "expected"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89995/new/

https://reviews.llvm.org/D89995



More information about the llvm-commits mailing list