[PATCH] D90334: [AMDGPU] Fix inserting combined s_nop in bundles

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.ds.gws.sema.p.ll:14
 ; LOOP-NEXT: s_setreg_imm32_b32 hwreg(HW_REG_TRAPSTS, 8, 1), 0
-; GFX8-NEXT: s_nop 0
 ; LOOP-NEXT: ds_gws_sema_p gds
----------------
kerbowa wrote:
> rampitec wrote:
> > rampitec wrote:
> > > Is this expected?
> > According to GCNHazardRecognizer::checkRFEHazards() it needs 1 waitstate.
> I don't think this is an RFE hazard.
Hm... Right, there is no rfe here...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90334/new/

https://reviews.llvm.org/D90334