[PATCH] D89087: [MemProf] Pass down memory profile name with optional path from clang

[David Li via Phabricator via llvm-commits]

davidxl added a comment.
Herald added a subscriber: dexonsmith.

There should be a related LLVM side of changes. Is it in a different patch?



================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:587
 
-  if (CodeGenOpts.CFProtectionBranch &&
-      Target.checkCFProtectionBranchSupported(getDiags())) {
-    // Indicate that we want to instrument branch control flow protection.
-    getModule().addModuleFlag(llvm::Module::Override, "cf-protection-branch",
+  if (CodeGenOpts.CFProtectionReturn &&
+      Target.checkCFProtectionReturnSupported(getDiags())) {
----------------
Is this change relevant?


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:613
+    llvm::LLVMContext &Ctx = TheModule.getContext();
+    getModule().addModuleFlag(
+        llvm::Module::Error, "MemProfProfileFilename",
----------------
Is there a need for a module flag? PGO passes an InstrProfOptions typed object to the instrumentation pass. The option object has the directory info.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89087/new/

https://reviews.llvm.org/D89087