[PATCH] D90330: [NFC][ThinLTO] Change command line passing to EmbedBitcodeInModule

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

lgtm except for the part that should go back into D90278 <https://reviews.llvm.org/D90278> as noted below.



================
Comment at: llvm/include/llvm/Bitcode/BitcodeWriter.h:165
   void EmbedBitcodeInModule(Module &M, MemoryBufferRef Buf, bool EmbedBitcode,
-                            bool EmbedMarker,
-                            const std::vector<uint8_t> *CmdArgs);
+                            bool EmbedCmdline,
+                            const std::vector<uint8_t> &CmdArgs);
----------------
The change of the parameter name and comment here should go back in D90278


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90330/new/

https://reviews.llvm.org/D90330