[PATCH] D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler

Wed Oct 28 12:13:14 PDT 2020

ekovanov added a comment.

In D86435#2357748 <https://reviews.llvm.org/D86435#2357748>, @lhames wrote:

> In D86435#2349843 <https://reviews.llvm.org/D86435#2349843>, @ekovanov wrote:
>
>> Thanks a lot for your help!
>> Being very new here, I do not have commit access to land this, could you please land this?
>
> Hi Elena,
>
> I missed that this included a definition of a git submodule. This would be the first in the main LLVM tree and I think we'd need to ask the community about inclusion. Is it required for this patch, or could it be dropped and downloading of that module left to clients who want to enable Intel JIT events support?

Hi Lang!

At my opinion, to add submodule is a good solution for open source project to be up to date with ITT API source.
The alternative solution - just add necessary source files from ITT API to the llvm/lib/ExecutionEngine/IntelJITEvents/ directory and manually update them from time to time.
How do you think, what is better to implement in my case?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86435/new/

https://reviews.llvm.org/D86435