[PATCH] D89995: Make the post-commit review expectations more explicit with respect to revert

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 12:06:20 PDT 2020


mehdi_amini added a comment.

In D89995#2359843 <https://reviews.llvm.org/D89995#2359843>, @gribozavr2 wrote:

> In D89995#2359635 <https://reviews.llvm.org/D89995#2359635>, @mehdi_amini wrote:
>
>> @gribozavr2 the paragraph now starts with "If shortly after landing a commit, a developer expresses concerns ..." ; WDYT?
>
> "If shortly after landing a commit, a developer expresses concerns" makes it sound like the developer landing and expressing are the same person. Try "If a community member expresses a concern about a recent commit, and this concern would have been significant enough to warrant a conversation during pre-commit review, ..."

Thanks! I applied this as-is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89995/new/

https://reviews.llvm.org/D89995



More information about the llvm-commits mailing list