[PATCH] D90326: [docs] Fix load instructions in chapter 7 of the tutorial
Mihaly Barasz via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 28 11:45:35 PDT 2020
klao created this revision.
klao added reviewers: Jim, kiszk.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
klao requested review of this revision.
Loads in the first half of the chapter are missing the type argument.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D90326
Files:
llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl07.rst
Index: llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl07.rst
===================================================================
--- llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl07.rst
+++ llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl07.rst
@@ -63,11 +63,11 @@
br i1 %Condition, label %cond_true, label %cond_false
cond_true:
- %X.0 = load i32* @G
+ %X.0 = load i32, i32* @G
br label %cond_next
cond_false:
- %X.1 = load i32* @H
+ %X.1 = load i32, i32* @H
br label %cond_next
cond_next:
@@ -126,7 +126,7 @@
entry:
%X = alloca i32 ; type of %X is i32*.
...
- %tmp = load i32* %X ; load the stack value %X from the stack.
+ %tmp = load i32, i32* %X ; load the stack value %X from the stack.
%tmp2 = add i32 %tmp, 1 ; increment it
store i32 %tmp2, i32* %X ; store it back
...
@@ -149,17 +149,17 @@
br i1 %Condition, label %cond_true, label %cond_false
cond_true:
- %X.0 = load i32* @G
+ %X.0 = load i32, i32* @G
store i32 %X.0, i32* %X ; Update X
br label %cond_next
cond_false:
- %X.1 = load i32* @H
+ %X.1 = load i32, i32* @H
store i32 %X.1, i32* %X ; Update X
br label %cond_next
cond_next:
- %X.2 = load i32* %X ; Read X
+ %X.2 = load i32, i32* %X ; Read X
ret i32 %X.2
}
@@ -191,11 +191,11 @@
br i1 %Condition, label %cond_true, label %cond_false
cond_true:
- %X.0 = load i32* @G
+ %X.0 = load i32, i32* @G
br label %cond_next
cond_false:
- %X.1 = load i32* @H
+ %X.1 = load i32, i32* @H
br label %cond_next
cond_next:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90326.301356.patch
Type: text/x-patch
Size: 1742 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201028/a06825d6/attachment.bin>
More information about the llvm-commits
mailing list