[PATCH] D90281: [FileCheck] Report missing prefixes when more than one is provided.

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 11:16:57 PDT 2020


mtrofin added a comment.

In D90281#2359673 <https://reviews.llvm.org/D90281#2359673>, @MaskRay wrote:

> @mtrofin I favor a detect-potential-mistake-by-default approach as well. If you want to take the lead here, we can take a busy beavers approach. Add the option (initially true by default), create a spreadsheet with ~1500 failures grouped by test directories, post to llvm-dev and encourage maintainers to fix the issues (I would expect most are user errors, not deliberate --allow-unused-prefixes). After the issues are fixed, make the option false by default.

Awesome, let's do that! The list is actually captured here - the failed unittests - but we can do a shared spreadsheet and go that way.

Let me add the flag first (need a few mins, should have it in by lunch)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90281/new/

https://reviews.llvm.org/D90281



More information about the llvm-commits mailing list