[PATCH] D90320: [llvm][StringExtras] Use a lookup table for `hexDigitValue`

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 11:08:32 PDT 2020


dexonsmith added a comment.

In D90320#2359587 <https://reviews.llvm.org/D90320#2359587>, @dblaikie wrote:

> If you like you could try rephrasing this as a programmatic initialization rather than writing it all out manually, might make it easier to read/look more like the original code (except applied as a loop over the range/table) and hopefully can be phrased in such a way that the compiler boils it down to the same values anyway.

Hmmm, yeah, that's better than my idea.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90320/new/

https://reviews.llvm.org/D90320



More information about the llvm-commits mailing list