[PATCH] D90304: [GlobalISel] Introduce optimal variant of regbankselect

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 11:05:26 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/RegBankSelect.cpp:1306
+      auto MO = MI.getOperand(i);
+      if (!isMachineOperandWithVirtualReg(MO)) {
+        continue;
----------------
I think checking if this is virtual is redundant; any instruction subject to rgebank select should not have physical register operands


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90304/new/

https://reviews.llvm.org/D90304



More information about the llvm-commits mailing list