[PATCH] D88982: [NFCI] Add StackOffset class and base classes for ElementCount, TypeSize.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 10:40:26 PDT 2020


sdesmalen marked an inline comment as done.
sdesmalen added inline comments.


================
Comment at: llvm/include/llvm/Support/TypeSize.h:180
+
+  UnivariateLinearPolyBase(ScalarTy &Val, unsigned UnivariateDim)
+      : Value(Val), UnivariateDim(UnivariateDim) {}
----------------
ctetreau wrote:
> georges wrote:
> > worth an assert that UniveriateDim is in range?
> I think this would be a useful assert
Agreed, good catch!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88982/new/

https://reviews.llvm.org/D88982



More information about the llvm-commits mailing list