[PATCH] D89397: [AMDGPU] SILowerControlFlow::removeMBBifRedundant should not try to change MBB layout if it can fallthrough

Wed Oct 28 09:05:19 PDT 2020

alex-t added a comment.

The new review opened to address curent improvements : https://reviews.llvm.org/D90314

================
Comment at: llvm/lib/Target/AMDGPU/SILowerControlFlow.cpp:711
+    if (GetFallThroughSucc(P) == &MBB)
+      FallThrough = P;
+    P->ReplaceUsesOfBlockWith(&MBB, Succ);
----------------
foad wrote:
> Assert !FallThrough here (i.e. assert that there is at most one block that falls through into MBB)?
There is already the check in IR verifier that asserts if the fallthrough block is the layout successor. As we only can have one layout successor there is only one fallthrough.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89397/new/

https://reviews.llvm.org/D89397