[PATCH] D90300: [flang][driver] Rename the accessors (NFC)

[Caroline via Phabricator via llvm-commits]

CarolineConcatto added a comment.

Thank you @awarzynski for changing this to be compatible with Flang style,  it is not the nicest job.
First time we implemented it was very different so I missed some standards.
What I notice is that you did not changed any of the get for diagnostic. Is there any reasons for that?



================
Comment at: flang/include/flang/Frontend/CompilerInstance.h:110-111
 
   /// Get the current diagnostics engine.
   clang::DiagnosticsEngine &GetDiagnostics() const {
     assert(diagnostics_ && "Compiler instance has no diagnostics!");
----------------
Is the diagnostic not changed because you want to have like it is in clang?
As for instance:
clang::DiagnosticsEngine &GetDiagnostics()
 void SetDiagnostics(clang::DiagnosticsEngine *value);


================
Comment at: flang/include/flang/Frontend/CompilerInstance.h:195
   /// {
   void SetOutputStream(std::unique_ptr<llvm::raw_pwrite_stream> outStream) {
     outputStream_ = std::move(outStream);
----------------
Should this also be changed?


================
Comment at: flang/lib/Frontend/CompilerInstance.cpp:29
 
 void CompilerInstance::SetInvocation(
     std::shared_ptr<CompilerInvocation> value) {
----------------
Should it be set_invocation?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90300/new/

https://reviews.llvm.org/D90300