[PATCH] D90307: [AMDGPU] Fix double space in disassembly of ds_gws_sema_* with gds

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 07:00:28 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/DSInstructions.td:333
 : DS_GWS<opName,
-  (ins offset:$offset, gds:$gds), "$offset gds"> {
+  (ins offset:$offset, gds:$gds), "${offset}gds"> {
   let hasSideEffects = 1;
----------------
Why is there a $gds operand here if it's not used for printing?


================
Comment at: llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp:142
+    if (OpNo == 0)
+      O << " ";
   }
----------------
Single quotes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90307/new/

https://reviews.llvm.org/D90307



More information about the llvm-commits mailing list