[PATCH] D90306: [flang][driver] Use --match-full-lines in tests for `-test-io`

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 06:44:34 PDT 2020


awarzynski created this revision.
Herald added a reviewer: sscalpone.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
awarzynski requested review of this revision.

Use `--match-full-lines` to make sure that FileCheck doesn't match the
output against the `CHECK` lines (which, like other comments, are also
printed).

More specifically, we want to make sure that the following `check` in the
input file:

  ! CHECK: <some-fortran-input>

is matched by FileCheck with `<some-fortran-input>` in the generated
output. Without `--match-full-lines`, that check-line will be matched
with `!CHECK:  <some-fortran-input>` instead (which is also
printed together with other contents of the file).

Adding `--match-full-lines` makes the tests stricter and this change
revealed that some `check`s were passing only because that flag was
missing. These are updated accordingly.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D90306

Files:
  flang/test/Frontend/input-output-file.f90
  flang/test/Frontend/multiple-input-files.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90306.301267.patch
Type: text/x-patch
Size: 6509 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201028/c0c6bdc3/attachment.bin>


More information about the llvm-commits mailing list